Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower discriminant_value intrinsic #79922

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Lower discriminant_value intrinsic #79922

merged 1 commit into from
Dec 15, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Dec 11, 2020

This allows const propagation to evaluate comparisons involving
field-less enums using derived implementations of PartialEq (after
inlining eq).

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2020
@tmiasko
Lower discriminant_value intrinsic
686237c 
This allows const propagation to evaluate comparisons involving
field-less enums using derived implementations of `PartialEq` (after
inlining `eq`).
@nagisa
Copy link
Member

nagisa commented Dec 13, 2020

@bors r+ rollup=never

(no rollups because has nontrivial perf implications)

@bors
Copy link
Contributor

bors commented Dec 13, 2020

📌 Commit 686237c has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2020
@bors
Copy link
Contributor

bors commented Dec 14, 2020

⌛ Testing commit 686237c with merge fb995b4da709a06800c50c4216a78a090840c5c4...

@bors
Copy link
Contributor

bors commented Dec 14, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 14, 2020
@varkor varkor assigned nagisa and unassigned varkor Dec 14, 2020
@nagisa
Copy link
Member

nagisa commented Dec 15, 2020

@bors retry

… I guess.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2020
@bors
Copy link
Contributor

bors commented Dec 15, 2020

⌛ Testing commit 686237c with merge 5d77fc8...

@bors
Copy link
Contributor

bors commented Dec 15, 2020

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 5d77fc8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 15, 2020
@bors bors merged commit 5d77fc8 into rust-lang:master Dec 15, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 15, 2020
@tmiasko tmiasko deleted the lower-discriminant branch December 15, 2020 10:10
@tmiasko tmiasko mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tmiasko @rust-highfive @nagisa @bors @varkor @rustbot